issues/27: CI PHPUnit gate on test and stage tags

.gitea/workflows/build.yml

@@ -1,6 +1,6 @@
 name: cabinet-ci-cd
 
-# CI/CD: только push git-тега (ручное тегирование на ветке prod|test|stage).
+# Pre-deploy PHPUnit on test|stage. Prod — без автотестов.
 
 on:
   push:
@@ -13,24 +13,6 @@ env:
   IMAGE_DEPLOY: git.sova.local/sova/cabinet
 
 jobs:
-  test:
-    if: false  # test contour: setup-php downloads hang on slow egress; build runs without blocking
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: '8.4'
-          extensions: pdo_pgsql, pdo_mysql, redis, intl, zip, gd
-      - name: Prepare CI environment
-        run: |
-          cp .env.ci .env.local
-          mkdir -p var
-      - run: composer install --prefer-dist --no-interaction
-      - run: composer phpunit || true
-      - run: composer audit || true
-
   parse-tag:
     runs-on: ubuntu-latest
     outputs:
@@ -46,8 +28,36 @@ jobs:
           echo "env=$(echo "$TAG" | sed -E 's/cabinet-v([0-9.]+)-([a-z]+)/\2/')" >> "$GITHUB_OUTPUT"
           echo "version=$(echo "$TAG" | sed -E 's/cabinet-v([0-9.]+).*/\1/')" >> "$GITHUB_OUTPUT"
 
-  build-and-push:
+  test:
     needs: [parse-tag]
+    if: needs.parse-tag.outputs.env != 'prod'
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.4'
+          extensions: pdo_pgsql, pdo_mysql, redis, intl, zip, gd
+      - name: Prepare CI environment
+        run: |
+          cp .env.ci .env.local
+          mkdir -p var
+      - run: composer install --prefer-dist --no-interaction
+      - name: PHPUnit
+        run: composer phpunit
+      - run: composer audit || true
+
+  test-prod-skip:
+    needs: [parse-tag]
+    if: needs.parse-tag.outputs.env == 'prod'
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo "Prod tag — automated tests skipped."
+
+  build-and-push:
+    needs: [parse-tag, test, test-prod-skip]
+    if: always() && (needs.test.result == 'success' || needs.test.result == 'skipped') && (needs.test-prod-skip.result == 'success' || needs.test-prod-skip.result == 'skipped')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -86,25 +96,23 @@ jobs:
           git config user.email "ci-bot@sova.local"
           git config user.name "sova-ci"
           MAX_RETRIES=5
-          bump_values() {
-            local file="apps/cabinet/values-${ENV}.yaml"
-            sed -i "s|^  repository:.*|  repository: ${IMAGE_DEPLOY}|" "$file"
-            sed -i "s|^  tag:.*|  tag: ${TAG}|" "$file"
-            sed -i "s|^  pullPolicy:.*|  pullPolicy: IfNotPresent|" "$file"
-          }
+          case "$(uname -m)" in
+            x86_64|amd64) YQ_ARCH=amd64 ;;
+            aarch64|arm64) YQ_ARCH=arm64 ;;
+            *) echo "Unsupported arch: $(uname -m)"; exit 1 ;;
+          esac
+          curl -sSL -o /usr/local/bin/yq "https://github.com/mikefarah/yq/releases/download/v4.44.3/yq_linux_${YQ_ARCH}"
+          chmod +x /usr/local/bin/yq
           for attempt in $(seq 1 $MAX_RETRIES); do
             git pull --rebase origin "${ENV}"
-            bump_values
+            yq -i ".image.repository = \"${IMAGE_DEPLOY}\"" "apps/cabinet/values-${ENV}.yaml"
+            yq -i ".image.tag = \"${TAG}\"" "apps/cabinet/values-${ENV}.yaml"
+            yq -i ".image.pullPolicy = \"IfNotPresent\"" "apps/cabinet/values-${ENV}.yaml"
             git add "apps/cabinet/values-${ENV}.yaml"
             git diff --cached --quiet && { echo "No changes"; exit 0; }
             git commit -m "chore(cabinet): bump ${ENV} to ${TAG}"
-            if git push origin "${ENV}"; then
-              echo "Push OK on attempt ${attempt}"
-              exit 0
-            fi
-            echo "Push failed, retry ${attempt}/${MAX_RETRIES}..."
+            if git push origin "${ENV}"; then exit 0; fi
             git reset --hard HEAD~1
             sleep $((attempt * 2))
           done
-          echo "Failed to push after ${MAX_RETRIES} attempts"
           exit 1

.gitignore

@@ -1,4 +1,5 @@
 ###> symfony/framework-bundle ###
+/.env
 /.env.local
 /.env.local.php
 /.env.*.local

assets/components/record.js

@@ -1,6 +1,7 @@
 const loader = require("./loader.js");
 const validator = require("./validator.js");
 const helper = require("./helper.js");
+const onlineModeUtil = require("./onlineMode.js");
 const Cookies = require('js-cookie');
 
 function renderFormRecord(userInfo, params) {
@@ -21,9 +22,9 @@ function renderFormRecord(userInfo, params) {
     popup.dataset.company = company;
     popup.dataset.comment = comment;
     popup.dataset.rnum = params.rnum;
-    popup.querySelector('.modal-title').innerHTML = (params.onlinemode === 'false')
-        ? 'Записаться к врачу'
-        : 'Запись на онлайн-консультацию'
+    popup.querySelector('.modal-title').innerHTML = onlineModeUtil.isOnlineMode(params.onlinemode)
+        ? 'Запись на онлайн-консультацию'
+        : 'Записаться к врачу'
     ;
 
     popup.querySelector('.modal-dialog').classList.remove('modal-lg');
@@ -35,7 +36,7 @@ function renderFormRecord(userInfo, params) {
 
     var licenseLink = helper.getLicenseLink(Cookies.get('region'));
     
-    if (params.onlinemode === 'false') {
+    if (!onlineModeUtil.isOnlineMode(params.onlinemode)) {
         var license = document.createElement('a');
         license.classList = "staff-info__review license-link";
         license.href = licenseLink;
@@ -881,11 +882,7 @@ function validateData(data) {
 }
 
 function sendReserve(el) {
-    if (el.dataset.onlinemode === 'true') {
-        var onlineMode = 1;
-    } else {
-        var onlineMode = 0;
-    }
+    var onlineMode = onlineModeUtil.toOnlineType(el.dataset.onlinemode);
 
     var workDate = new Date(el.dataset.workDate);
     var time = el.dataset.time.split('-');

src/Controller/PublicAPIController.php

@@ -3,6 +3,7 @@
 namespace App\Controller;
 
 use App\Bundle\Infoclinica\Region;
+use App\Support\OnlineMode;
 use App\Entity\Record;
 use App\Entity\PriceDepartment;
 use App\Entity\PriceList;
@@ -226,7 +227,7 @@ class PublicAPIController extends AbstractController
         $doctor = $request->query->get('doctor');
         $department = $request->query->get('department');
         $filial = $request->query->get('filial');
-        $onlineMode = $request->query->get('onlineMode')? true: false;
+        $onlineMode = OnlineMode::isOnline($request->query->get('onlineMode'));
         $isFree = true;
         $nearestDate = NULL;
 

src/Controller/SpecialistController.php

@@ -119,7 +119,7 @@ SpecialistService $specialistService,
         $kinder = ($kinder == 1) ? 1 : null;
         
         $searchForm = $this->createForm(SpecialistSearchType::class, new SpecialistView(), [
-            'action' => $this->generateUrl('specialist_index'),
+            'action' => $this->generateUrl('specialist_online_index'),
             'method' => 'GET',
             'regionId' => $regionId,
             'kinder' => $kinder,
@@ -128,6 +128,7 @@ SpecialistService $specialistService,
         $searchForm->handleRequest($request);
 
         $filters = $request->query->get('specialist_search', ['onlineMode' => 1]);
+        $filters['onlineMode'] = 1;
         
         if ($regionId > 0) {
             $filters['regionId'] = $regionId;

src/Repository/SpecialistViewRepository.php

@@ -3,6 +3,7 @@
 namespace App\Repository;
 
 use App\Entity\SpecialistView;
+use App\Support\OnlineMode;
 use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 use Doctrine\ORM\QueryBuilder;
@@ -28,12 +29,20 @@ class SpecialistViewRepository extends ServiceEntityRepository
     private function applyFilters(QueryBuilder $qb, array $filters): void
     {
         foreach ($filters as $key => $value) {
+            // onlineMode=0 — валидный фильтр; empty(0) в PHP === true, поэтому обрабатываем отдельно.
+            if ($key === 'onlineMode') {
+                if ($value === null || $value === '') {
+                    continue;
+                }
+                $this->applyOnlineModeFilter($qb, OnlineMode::isOnline($value));
+                continue;
+            }
+
             if (empty($value)) {
                 continue;
             }
 
             match ($key) {
-                'onlineMode' => $this->applyOnlineModeFilter($qb, $value),
                 'regionId' => $this->applyRegionFilter($qb, $value),
                 'alias' => $this->applyAliasFilter($qb, $value),
                 'filial' => $this->applyFilialFilter($qb, $value),

src/Twig/AppExtension.php

@@ -180,8 +180,12 @@ class AppExtension extends AbstractExtension
     }
 
     public function isMobile() {
-        $useragent = $_SERVER['HTTP_USER_AGENT'];
-        
+        $useragent = $_SERVER['HTTP_USER_AGENT'] ?? '';
+
+        if ($useragent === '') {
+            return false;
+        }
+
         return preg_match('/(android|bb\d+|meego).+mobile|avantgo|bada\/|blackberry|blazer|compal|elaine|fennec|hiptop|iemobile|ip(hone|od)|iris|kindle|lge |maemo|midp|mmp|netfront|opera m(ob|in)i|palm( os)?|phone|p(ixi|re)\/|plucker|pocket|psp|series(4|6)0|symbian|treo|up\.(browser|link)|vodafone|wap|windows (ce|phone)|xda|xiino/i',$useragent)
             || preg_match('/1207|6310|6590|3gso|4thp|50[1-6]i|770s|802s|a wa|abac|ac(er|oo|s\-)|ai(ko|rn)|al(av|ca|co)|amoi|an(ex|ny|yw)|aptu|ar(ch|go)|as(te|us)|attw|au(di|\-m|r |s )|avan|be(ck|ll|nq)|bi(lb|rd)|bl(ac|az)|br(e|v)w|bumb|bw\-(n|u)|c55\/|capi|ccwa|cdm\-|cell|chtm|cldc|cmd\-|co(mp|nd)|craw|da(it|ll|ng)|dbte|dc\-s|devi|dica|dmob|do(c|p)o|ds(12|\-d)|el(49|ai)|em(l2|ul)|er(ic|k0)|esl8|ez([4-7]0|os|wa|ze)|fetc|fly(\-|_)|g1 u|g560|gene|gf\-5|g\-mo|go(\.w|od)|gr(ad|un)|haie|hcit|hd\-(m|p|t)|hei\-|hi(pt|ta)|hp( i|ip)|hs\-c|ht(c(\-| |_|a|g|p|s|t)|tp)|hu(aw|tc)|i\-(20|go|ma)|i230|iac( |\-|\/)|ibro|idea|ig01|ikom|im1k|inno|ipaq|iris|ja(t|v)a|jbro|jemu|jigs|kddi|keji|kgt( |\/)|klon|kpt |kwc\-|kyo(c|k)|le(no|xi)|lg( g|\/(k|l|u)|50|54|\-[a-w])|libw|lynx|m1\-w|m3ga|m50\/|ma(te|ui|xo)|mc(01|21|ca)|m\-cr|me(rc|ri)|mi(o8|oa|ts)|mmef|mo(01|02|bi|de|do|t(\-| |o|v)|zz)|mt(50|p1|v )|mwbp|mywa|n10[0-2]|n20[2-3]|n30(0|2)|n50(0|2|5)|n7(0(0|1)|10)|ne((c|m)\-|on|tf|wf|wg|wt)|nok(6|i)|nzph|o2im|op(ti|wv)|oran|owg1|p800|pan(a|d|t)|pdxg|pg(13|\-([1-8]|c))|phil|pire|pl(ay|uc)|pn\-2|po(ck|rt|se)|prox|psio|pt\-g|qa\-a|qc(07|12|21|32|60|\-[2-7]|i\-)|qtek|r380|r600|raks|rim9|ro(ve|zo)|s55\/|sa(ge|ma|mm|ms|ny|va)|sc(01|h\-|oo|p\-)|sdk\/|se(c(\-|0|1)|47|mc|nd|ri)|sgh\-|shar|sie(\-|m)|sk\-0|sl(45|id)|sm(al|ar|b3|it|t5)|so(ft|ny)|sp(01|h\-|v\-|v )|sy(01|mb)|t2(18|50)|t6(00|10|18)|ta(gt|lk)|tcl\-|tdg\-|tel(i|m)|tim\-|t\-mo|to(pl|sh)|ts(70|m\-|m3|m5)|tx\-9|up(\.b|g1|si)|utst|v400|v750|veri|vi(rg|te)|vk(40|5[0-3]|\-v)|vm40|voda|vulc|vx(52|53|60|61|70|80|81|83|85|98)|w3c(\-| )|webc|whit|wi(g |nc|nw)|wmlb|wonu|x700|yas\-|your|zeto|zte\-/i',substr($useragent,0,4));
     }